[APIView] Identify the package type #12398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helen229
requested review from
AlitzelMendez,
chidozieononiwu and
praveenkuttappan
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces package type classification functionality to the API review system. The main purpose is to enable categorization of packages as Data plane, Management plane, or Unknown types throughout the review workflow.
Key changes include:
- Added PackageType enum and supporting infrastructure for package classification
- Enhanced review creation and update workflows to handle package type assignment
- Improved error handling and code organization in the review page component
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/dotnet/APIView/ClientSPA/src/app/_models/review.ts | Added PackageType enum and optional packageType field to Review class |
| src/dotnet/APIView/ClientSPA/src/app/_components/review-page/review-page.component.ts | Added updateReview method, improved error handling, and consolidated review update logic |
| src/dotnet/APIView/APIViewWeb/Managers/ReviewManager.cs | Added packageType parameter to CreateReviewAsync and new UpdateReviewAsync method |
| src/dotnet/APIView/APIViewWeb/Managers/PullRequestManager.cs | Enhanced pull request workflow to support package type classification |
| src/dotnet/APIView/APIViewWeb/Managers/Interfaces/IReviewManager.cs | Updated interface signatures for package type support |
| src/dotnet/APIView/APIViewWeb/Managers/Interfaces/IPullRequestManager.cs | Added packageType parameter to interface method |
| src/dotnet/APIView/APIViewWeb/LeanModels/ReviewListModels.cs | Added PackageType property to ReviewListItemModel |
| src/dotnet/APIView/APIViewWeb/LeanControllers/ReviewsController.cs | Added blank lines (formatting change) |
| src/dotnet/APIView/APIViewWeb/LeanControllers/PullRequestsController.cs | Added packageType parameter to API endpoint |
| src/dotnet/APIView/APIViewWeb/Helpers/CommonUtilities.cs | Defined PackageType enum with Data, Management, and Unknown values |
| src/dotnet/APIView/APIViewWeb/Controllers/AutoReviewController.cs | Enhanced auto-review workflow with package type classification support |
src/dotnet/APIView/APIViewWeb/LeanControllers/ReviewsController.cs
Outdated
Show resolved
Hide resolved
…r.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
tjprescott
requested changes
Oct 7, 2025
src/dotnet/APIView/APIViewWeb/Controllers/AutoReviewController.cs
Outdated
Show resolved
Hide resolved
src/dotnet/APIView/ClientSPA/src/app/_components/review-page/review-page.component.ts
Outdated
Show resolved
Hide resolved
tjprescott
reviewed
Oct 7, 2025
Member
tjprescott
left a comment
tjprescott
left a comment
There was a problem hiding this comment.
Overall LGTM, but would like sign-off from @praveenkuttappan since he has more knowledge of the C# side of APIView than me.
src/dotnet/APIView/APIViewWeb/Controllers/AutoReviewController.cs
Outdated
Show resolved
Hide resolved
src/dotnet/APIView/APIViewWeb/Controllers/AutoReviewController.cs
Outdated
Show resolved
Hide resolved
src/dotnet/APIView/APIViewWeb/Controllers/AutoReviewController.cs
Outdated
Show resolved
Hide resolved
src/dotnet/APIView/ClientSPA/src/app/_components/review-page/review-page.component.ts
Outdated
Show resolved
Hide resolved
maririos
reviewed
Oct 13, 2025
Member
maririos
left a comment
maririos
left a comment
There was a problem hiding this comment.
could you add tests to make sure the package type is correctly populated in all types of APIViews creations?
praveenkuttappan
requested changes
Oct 14, 2025
src/dotnet/APIView/APIViewWeb/Controllers/AutoReviewController.cs
Outdated
Show resolved
Hide resolved
src/dotnet/APIView/APIViewWeb/Controllers/AutoReviewController.cs
Outdated
Show resolved
Hide resolved
praveenkuttappan
approved these changes
Oct 16, 2025
tjprescott
approved these changes
Oct 16, 2025
maririos
reviewed
Oct 17, 2025
Member
maririos
left a comment
maririos
left a comment
There was a problem hiding this comment.
Can you ensure that there are tests covering:
- Passing a valid
packageType - Passing an invalid
packageType - Omitting
packageType - Updating an existing review with and without
PackageTypeset
maririos
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12242